Improve error message when shifting int by non-const #4653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
added
enhancement
ChrisDodd
approved these changes
May 6, 2024
Yes, I believe this is necessary to fold compile-time arithmetic in It could then be extended by the full ConstantFolding pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4652. Note that besides changing the error I've also allowed the case when the right operand is
bit<N>/int<N>but it is also constant. This case should be allowed and it does actually work in most cases in practice, it is just covered by constant folding.BTW: I did not realize until now that the type checker actually does constant folding too! This will make any "small frontend" quite hard to do if it was to not do constant folding.